-
Notifications
You must be signed in to change notification settings - Fork 395
Conversation
FYI - The current API for creating is |
This PR requires - angular/components#8546 |
* description: description, | ||
* // Private or not | ||
* private: true | ||
* // Depedencies | ||
* depedencies: depedencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: dependencies
* | ||
* Plunker API | ||
* StackBlitz API | ||
* URL: http://plnkr.co/edit/?p=preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update url
|
||
const TAGS: string[] = ['angular', 'material', 'example']; | ||
|
||
const depedencies = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: dependencies
@willshowell - Fixed; thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two small comments
|
||
const TAGS: string[] = ['angular', 'material', 'example']; | ||
|
||
const dependencies = { | ||
'@angular/cdk': '^5.0.0-rc0', | ||
'@angular/material': '^5.0.0-rc0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rc.1 now
|
||
const TAGS: string[] = ['angular', 'material', 'example']; | ||
|
||
const dependencies = { | ||
'@angular/cdk': '^5.0.0-rc0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Break out the versions for the two release tracks?
const angularVersion = '^5.0.0';
const materialVersion = '^5.0.0-rc.1';
Done and bumped to new api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR converts plunker demos to stackblitz.