Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

chore(*): stackblitz conversion #331

Merged
merged 3 commits into from
Nov 27, 2017
Merged

chore(*): stackblitz conversion #331

merged 3 commits into from
Nov 27, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Nov 19, 2017

This PR converts plunker demos to stackblitz.

@amcdnl
Copy link
Contributor Author

amcdnl commented Nov 19, 2017

FYI - The current API for creating is aio ( https://github.com/angular/material.angular.io/pull/331/files#diff-f4d2d04dd15dd9caac319319cad1a1c4R7 ), @EricSimons is gonna change it to just angular.

@amcdnl
Copy link
Contributor Author

amcdnl commented Nov 19, 2017

This PR requires - angular/components#8546

* description: description,
* // Private or not
* private: true
* // Depedencies
* depedencies: depedencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: dependencies

*
* Plunker API
* StackBlitz API
* URL: http://plnkr.co/edit/?p=preview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update url


const TAGS: string[] = ['angular', 'material', 'example'];

const depedencies = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: dependencies

@amcdnl
Copy link
Contributor Author

amcdnl commented Nov 19, 2017

@willshowell - Fixed; thanks!

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two small comments


const TAGS: string[] = ['angular', 'material', 'example'];

const dependencies = {
'@angular/cdk': '^5.0.0-rc0',
'@angular/material': '^5.0.0-rc0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rc.1 now


const TAGS: string[] = ['angular', 'material', 'example'];

const dependencies = {
'@angular/cdk': '^5.0.0-rc0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break out the versions for the two release tracks?

const angularVersion = '^5.0.0';
const materialVersion = '^5.0.0-rc.1';

@amcdnl
Copy link
Contributor Author

amcdnl commented Nov 25, 2017

Done and bumped to new api

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit f775248 into angular:master Nov 27, 2017
@amcdnl amcdnl deleted the stackblitz branch November 27, 2017 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants